fix(android): Test keyman-staging i18n#15933
Closed
darcywong00 wants to merge 2 commits into
Closed
Conversation
keymanapp-test-bot
Bot
added
has-user-test
user-test-required
User Test ResultsTest specification and instructions
Results TemplateTest Artifacts |
Member
I would like to eliminate this. We should not be reliant on the layout of the website in the app code -- as we can see, that's a painful dependency. |
Contributor
Author
iirc, we use the regex to keep keyman.com/keyboards searches within the in-app webview and send all other links to external browser. |
Contributor
Author
|
Abandoning - Depends on analysis from #15948 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on keymanapp/keyman.com#730
This updates the Keyman for Android alpha pre-release to test the i81n of keyman-staging.com
The original implementation of i18n on keyman.com relied on passing a
lang=query parameter. Now, the locale is specified first in the URL.Changes:
INTERNAL_KEYBOARDS_LINK_FORMATSTRregex to allow for (optional) BCP-47 code inhost/{bcp-47}/keyboards... The regex validated if a keyboard link was an internal Keyman.com link./go/android/{bcp-47}/{version}/download-keyboards/...(ties to fix: Update /go/android links for BCP-47 🌋 keyman.com#730)User Testing
Setup - Install the PR build of Keyman for Android on an Android device/emulator. Start with device in English locale